[Fix] Align OpenAI vllm_xargs value types across request schemas#48252
Open
sagearc wants to merge 9 commits into
Open
[Fix] Align OpenAI vllm_xargs value types across request schemas#48252sagearc wants to merge 9 commits into
sagearc wants to merge 9 commits into
Conversation
Signed-off-by: Sage Ahrac <sagiahrak@gmail.com>
sagearc
requested review from
DarkLight1337,
aarnphm,
chaunceyjiang and
russellb
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Signed-off-by: Sage <80211083+sagearc@users.noreply.github.com>
Signed-off-by: Sage <80211083+sagearc@users.noreply.github.com>
Removed type aliases for VLLMXArgsValue and VLLMXArgs. Signed-off-by: Sage <80211083+sagearc@users.noreply.github.com>
Signed-off-by: Sage <80211083+sagearc@users.noreply.github.com>
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Sage Ahrac <sagiahrak@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some OpenAI request schemas accepted list-valued
vllm_xargswhile completion requests only accepted scalar values. This aligns the sharedvllm_xargstype across completions, chat completions, and responses.split out from #47922